d0p1/ack
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

In PowerPC top, don't delete addi r0, r0, 0

Browse source 
Also don't delete addis r0, r0, 0.  These instructions are special
cases that set r0 to zero.  If we delete them, then r0 keeps its old
value.

I caught this bug because osxppc protects the .text segment against
writing.  (linuxppc doesn't protect it.)  A program tried to set r0 to
the NULL pointer, but top deleted the instruction, so r0 kept an old
return address pointing into .text.  Later the program checked that r0
wasn't NULL, tried to write to address r0, and crashed.
This commit is contained in:
George Koehler 2017-01-26 12:44:32 -05:00
parent 8c8f291a07
commit 1dfd5524e4
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
mach/powerpc/top/table
View file

@ -6,15 +6,15 @@ LABEL_STARTER '.';
%%;
P, Q, R { TRUE };
RNZ { strcmp(VAL, "r0") }; /* not r0 */
X, Y, Z { TRUE };
%%;
/* Whitespace is significant here! */
addi X, X, 0 -> ;
addis X, X, 0 -> ;
addi RNZ, RNZ, 0 -> ;
addis RNZ, RNZ, 0 -> ;
mr X, X -> ;
fmr X, X -> ;