d0p1/ack
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Remove extra conversion of shift count in ACK C.

Browse source 
Given `long long o1` and `unsigned int o2`, then `o1 << o2` was
converting o2 to long long and then to int.  Remove the first
conversion and just convert o2 to int.
This commit is contained in:
George Koehler 2019-09-16 21:35:38 -04:00
parent f6a1e08218
commit 485faa2944
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lang/cem/cemcom.ansi/arith.c
View file

@ -143,7 +143,11 @@ void arithbalance(register struct expr **e1p, int oper, register struct expr **e
converted to the signed type, else both operands are converted to the signed type, else both operands are
converted to an unsigned type. converted to an unsigned type.
*/ */
if (t1 == LNGLNG && u1 && (t2 != LNGLNG || !u2)) if (shifting) {
/* In shifts like o1 << o2, never convert o1,
and let ch3bin() convert o2 to int.
*/
} else if (t1 == LNGLNG && u1 && (t2 != LNGLNG || !u2))
convert2 = ulnglng_type; convert2 = ulnglng_type;
else if (t2 == LNGLNG && u2 && (t1 != LNGLNG || !u1)) else if (t2 == LNGLNG && u2 && (t1 != LNGLNG || !u1))
convert1 = ulnglng_type; convert1 = ulnglng_type;
@ -180,7 +184,7 @@ void arithbalance(register struct expr **e1p, int oper, register struct expr **e
else if (t2 == LONG && t1 != LONG) else if (t2 == LONG && t1 != LONG)
convert1 = long_type; convert1 = long_type;
if (convert1 && !shifting) /* ??? */ if (convert1)
t1 = int2int(e1p, convert1); t1 = int2int(e1p, convert1);
if (convert2) if (convert2)
t2 = int2int(e2p, convert2); t2 = int2int(e2p, convert2);