d0p1/ack
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Don't print a string after possibly freeing it.

Browse source 
new= newvar(name) takes ownership of the string and might free its
memory.  Don't print name.  Do print new->v_name.

Also #include <string.h> for strcmp().
This commit is contained in:
George Koehler 2016-11-13 11:55:09 -05:00
parent 65278bc9a9
commit e617f42503
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
util/ack/svars.c
View file

@ -4,6 +4,7 @@
* *
*/ */
#include <string.h>
#include "ack.h" #include "ack.h"
#ifndef NORCSID #ifndef NORCSID
@ -81,7 +82,7 @@ void setsvar(char *name, char *str) {
new= newvar(name); new= newvar(name);
#ifdef DEBUG #ifdef DEBUG
if ( debug>=2 ) vprint("%s=%s\n", name, str) ; if ( debug>=2 ) vprint("%s=%s\n", new->v_name, str) ;
#endif #endif
new->v_type= string; new->v_type= string;
new->v_value.v_string= str; new->v_value.v_string= str;
@ -92,7 +93,7 @@ void setpvar(char *name, char *(*rout)(void)) {
new= newvar(name); new= newvar(name);
#ifdef DEBUG #ifdef DEBUG
if ( debug>=2 ) vprint("%s= (*%o)()\n",name,rout) ; if ( debug>=2 ) vprint("%s= (*%o)()\n", new->v_name, rout) ;
#endif #endif
new->v_type= routine; new->v_type= routine;
new->v_value.v_routine= rout; new->v_value.v_routine= rout;