Array descriptor ranges are inclusive; adjust aar and the tests to check for

this. All the tests except rotate build now!

mach/mips/libem/aar4.s

@@ -10,7 +10,7 @@
  * An array descriptor is:
  *
  *   +0 lower bound
- *   +4 range (upper bound - lower bound)
+ *   +4 range (upper bound - lower bound); *inclusive*
  *   +8 element size
  */
 
@@ -28,8 +28,8 @@
 	subu r5, r5, r7         ! adjust index for non-zero lower bound
 
 	lw at, 4(r4)            ! at = range
-	slt at, r5, at          ! at = adjusted index < range
+	slt at, at, r5          ! at = range < adjusted index
-	beq at, zero, .trap_earray
+	bne at, zero, .trap_earray
 	nop
 
 	lw r2, 8(r4)            ! r2 = size of element

plat/linuxmips/tests/build.lua

@@ -4,5 +4,5 @@ plat_testsuite {
     name = "tests",
     plat = "linuxmips",
     method = "qemu-mipsel",
-    skipsets = {"m2"}
+--	skipsets = {"m2"},
 }

tests/plat/core/aar_e.e

@@ -13,7 +13,7 @@ array
 
 descriptor
 	con -1			; lower bound
-	con 3			; range
+	con 2			; range, *inclusive*
 	con EM_WSIZE	; size of element
 
 

tests/plat/core/lar_e.e

@@ -17,7 +17,7 @@ array
 
 descriptor
 	con -1			; lower bound
-	con 3			; range
+	con 2			; range, *inclusive*
 	con EM_WSIZE	; size of element
 
 	exp $_m_a_i_n

tests/plat/core/sar_e.e

@@ -15,7 +15,7 @@ array
 
 descriptor
 	con -1			; lower bound
-	con 3			; range
+	con 2			; range, *inclusive*
 	con EM_WSIZE	; size of element
 
 element0