d0p1/ack
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't retry fork() in a loop.

Browse source 
If fork() fails, then report a fatal error.  Don't spin the cpu
retrying fork() until it succeeds.  It can fail when we reach a limit
on the number of processes.  Spinning on the cpu would slow down other
processes when we want them to exit.  This would get bad if we had a
parallel build with multiple ack processes spinning.
This commit is contained in:
George Koehler 2016-11-13 12:45:01 -05:00
parent e617f42503
commit fafc8a0b8a
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
util/ack/run.c
View file

@ -80,7 +80,10 @@ static int run_exec(trf *phase, const char *prog) {
fflush(stdout) ;
fflush(stderr) ;
while ( (child=fork())== -1 ) ;
child= fork() ;
if ( child== - 1) {
fatal("Cannot fork %s", prog) ;
}
if ( child ) {
/* The parent */
do {