From 03b30863279b111fb6b9f154a9bdaa831114adfb Mon Sep 17 00:00:00 2001 From: Saarett Date: Sun, 5 Feb 2017 12:44:56 +0200 Subject: [PATCH] Free pgdir in setupkvm in case of mappages failure There is a potential memory leak when mappages() fails inside setupkvm(). A call to freevm() is added in this case so as to reclaim the lost mapping pages. --- vm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/vm.c b/vm.c index 9db8b67..39642f4 100644 --- a/vm.c +++ b/vm.c @@ -137,8 +137,10 @@ setupkvm(void) panic("PHYSTOP too high"); for(k = kmap; k < &kmap[NELEM(kmap)]; k++) if(mappages(pgdir, k->virt, k->phys_end - k->phys_start, - (uint)k->phys_start, k->perm) < 0) + (uint)k->phys_start, k->perm) < 0) { + freevm(pgdir); return 0; + } return pgdir; }