ilo-pona/xv6-65oo2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Activity

consolewrite does not need cons.lock -- can lead to sleep() with lock held

Browse source
This commit is contained in:
Robert Morris 2020-10-20 06:55:51 -04:00 • committed by Frans Kaashoek
parent d4cecb269f
commit 13dccb0380
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
kernel/console.c
View file

@ -60,14 +60,12 @@ consolewrite(int user_src, uint64 src, int n)
{ {
int i; int i;
acquire(&cons.lock);
for(i = 0; i < n; i++){ for(i = 0; i < n; i++){
char c; char c;
if(either_copyin(&c, user_src, src+i, 1) == -1) if(either_copyin(&c, user_src, src+i, 1) == -1)
break; break;
uartputc(c); uartputc(c);
} }
release(&cons.lock);
return i; return i;
} }