From 286b2f3c3306a621c415e8c7ce67bc2a6501998a Mon Sep 17 00:00:00 2001 From: Robert Morris Date: Tue, 20 Oct 2020 06:55:51 -0400 Subject: [PATCH] consolewrite does not need cons.lock -- can lead to sleep() with lock held --- kernel/console.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/console.c b/kernel/console.c index d606ed2..23a2d35 100644 --- a/kernel/console.c +++ b/kernel/console.c @@ -60,14 +60,12 @@ consolewrite(int user_src, uint64 src, int n) { int i; - acquire(&cons.lock); for(i = 0; i < n; i++){ char c; if(either_copyin(&c, user_src, src+i, 1) == -1) break; uartputc(c); } - release(&cons.lock); return i; }