From 872fa88e8afd24a8f228ba431fad380d326b0f36 Mon Sep 17 00:00:00 2001 From: Robert Morris Date: Wed, 10 Aug 2022 06:13:52 -0400 Subject: [PATCH] tolerate running out of disk blocks --- kernel/fs.c | 42 +++++++++++++++++++++++++++++++----------- user/usertests.c | 46 +++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 76 insertions(+), 12 deletions(-) diff --git a/kernel/fs.c b/kernel/fs.c index 40c9bd4..247a86f 100644 --- a/kernel/fs.c +++ b/kernel/fs.c @@ -61,6 +61,7 @@ bzero(int dev, int bno) // Blocks. // Allocate a zeroed disk block. +// returns 0 if out of disk space. static uint balloc(uint dev) { @@ -82,7 +83,8 @@ balloc(uint dev) } brelse(bp); } - panic("balloc: out of blocks"); + printf("balloc: out of blocks\n"); + return 0; } // Free a disk block. @@ -109,8 +111,8 @@ bfree(int dev, uint b) // its size, the number of links referring to it, and the // list of blocks holding the file's content. // -// The inodes are laid out sequentially on disk at -// sb.startinode. Each inode has a number, indicating its +// The inodes are laid out sequentially on disk at block +// sb.inodestart. Each inode has a number, indicating its // position on the disk. // // The kernel keeps a table of in-use inodes in memory @@ -374,6 +376,7 @@ iunlockput(struct inode *ip) // Return the disk block address of the nth block in inode ip. // If there is no such block, bmap allocates one. +// returns 0 if out of disk space. static uint bmap(struct inode *ip, uint bn) { @@ -381,21 +384,32 @@ bmap(struct inode *ip, uint bn) struct buf *bp; if(bn < NDIRECT){ - if((addr = ip->addrs[bn]) == 0) - ip->addrs[bn] = addr = balloc(ip->dev); + if((addr = ip->addrs[bn]) == 0){ + addr = balloc(ip->dev); + if(addr == 0) + return 0; + ip->addrs[bn] = addr; + } return addr; } bn -= NDIRECT; if(bn < NINDIRECT){ // Load indirect block, allocating if necessary. - if((addr = ip->addrs[NDIRECT]) == 0) - ip->addrs[NDIRECT] = addr = balloc(ip->dev); + if((addr = ip->addrs[NDIRECT]) == 0){ + addr = balloc(ip->dev); + if(addr == 0) + return 0; + ip->addrs[NDIRECT] = addr; + } bp = bread(ip->dev, addr); a = (uint*)bp->data; if((addr = a[bn]) == 0){ - a[bn] = addr = balloc(ip->dev); - log_write(bp); + addr = balloc(ip->dev); + if(addr){ + a[bn] = addr; + log_write(bp); + } } brelse(bp); return addr; @@ -464,7 +478,10 @@ readi(struct inode *ip, int user_dst, uint64 dst, uint off, uint n) n = ip->size - off; for(tot=0; totdev, bmap(ip, off/BSIZE)); + uint addr = bmap(ip, off/BSIZE); + if(addr == 0) + break; + bp = bread(ip->dev, addr); m = min(n - tot, BSIZE - off%BSIZE); if(either_copyout(user_dst, dst, bp->data + (off % BSIZE), m) == -1) { brelse(bp); @@ -495,7 +512,10 @@ writei(struct inode *ip, int user_src, uint64 src, uint off, uint n) return -1; for(tot=0; totdev, bmap(ip, off/BSIZE)); + uint addr = bmap(ip, off/BSIZE); + if(addr == 0) + break; + bp = bread(ip->dev, addr); m = min(n - tot, BSIZE - off%BSIZE); if(either_copyin(bp->data + (off % BSIZE), user_src, src, m) == -1) { brelse(bp); diff --git a/user/usertests.c b/user/usertests.c index 0fe7371..4ab34da 100644 --- a/user/usertests.c +++ b/user/usertests.c @@ -2706,6 +2706,49 @@ execout(char *s) exit(0); } +// can the kernel tolerate running out of disk space? +void +diskfull(char *s) +{ + int fi; + int done = 0; + + for(fi = 0; done == 0; fi++){ + char name[32]; + name[0] = 'b'; + name[1] = 'i'; + name[2] = 'g'; + name[3] = '0' + fi; + name[4] = '\0'; + unlink(name); + int fd = open(name, O_CREATE|O_RDWR|O_TRUNC); + if(fd < 0){ + printf("%s: could not create file %s\n", s, name); + done = 1; + break; + } + for(int i = 0; i < MAXFILE; i++){ + char buf[BSIZE]; + if(write(fd, buf, BSIZE) != BSIZE){ + done = 1; + close(fd); + break; + } + } + close(fd); + } + + for(int i = 0; i < fi; i++){ + char name[32]; + name[0] = 'b'; + name[1] = 'i'; + name[2] = 'g'; + name[3] = '0' + i; + name[4] = '\0'; + unlink(name); + } +} + // // use sbrk() to count how many free physical memory pages there are. // touches the pages to force allocation. @@ -2818,7 +2861,7 @@ main(int argc, char *argv[]) void (*f)(char *); char *s; } tests[] = { - {MAXVAplus, "MAXVAplus"}, + {diskfull, "diskfull"}, {manywrites, "manywrites"}, {execout, "execout"}, {copyin, "copyin"}, @@ -2880,6 +2923,7 @@ main(int argc, char *argv[]) {dirfile, "dirfile"}, {iref, "iref"}, {forktest, "forktest"}, + {MAXVAplus, "MAXVAplus"}, {bigdir, "bigdir"}, // slow { 0, 0}, };