tweaks

BUGS

@@ -12,3 +12,7 @@ formatting:
 	file.c filewrite leaks onto next page
 	need to fix PAGEBREAK mechanism
 
+fs.c: grep XXX
+
+sysfile.c: why does mknod take a type argument?
+

fs.c

@@ -524,11 +524,11 @@ dirlink(struct inode *dp, char *name, uint ino)
 {
   int off;
   struct dirent de;
-  struct uinode *ip;
+  struct uinode *ipu;
 
   // Check that name is not present.
-  if((ip = dirlookup(dp, name, 0)) != 0){
+  if((ipu = dirlookup(dp, name, 0)) != 0){
-    iput(ip);
+    iput(ipu);
     return -1;
   }
 
@@ -593,43 +593,39 @@ skipelem(char *path, char *name)
 static struct uinode*
 _namei(char *path, int parent, char *name)
 {
-  struct uinode *dp, *ip;
+  struct uinode *dpu, *ipu;
-  struct inode *dpl;
+  struct inode *dp;
   uint off;
 
   if(*path == '/')
-    dp = iget(ROOTDEV, 1);
+    dpu = iget(ROOTDEV, 1);
   else
-    dp = idup(cp->cwd);
+    dpu = idup(cp->cwd);
 
   while((path = skipelem(path, name)) != 0){
-    dpl = ilock(dp);
+    dp = ilock(dpu);
-    if(dpl->type != T_DIR){
+    if(dp->type != T_DIR){
-      iunlock(dpl);
+      iput(iunlock(dp));
-      iput(dp);
       return 0;
     }
     
     if(parent && *path == '\0'){
       // Stop one level early.
-      iunlock(dpl);
+      iunlock(dp);
-      return dp;
+      return dpu;
     }
 
-    if((ip = dirlookup(dpl, name, &off)) == 0){
+    if((ipu = dirlookup(dp, name, &off)) == 0){
-      iunlock(dpl);
+      iput(iunlock(dp));
-      iput(dp);
+      iput(ipu);
-      iput(ip);
       return 0;
     }
-
+    iput(iunlock(dp));
-    iunlock(dpl);
+    dpu = ipu;
-    iput(dp);
-    dp = ip;
   }
   if(parent)
     return 0;
-  return dp;
+  return dpu;
 }
 
 struct uinode*

runoff.list

@@ -46,9 +46,9 @@ fsvar.h
 ide.c
 bio.c
 fs.c
-exec.c
 file.c
 sysfile.c
+exec.c
 
 # pipes
 pipe.c