Commit graph

1145 commits

Author SHA1 Message Date
Russ Cox 1a81e38b17 make new code like old code
Variable declarations at top of function,
separate from initialization.

Use == 0 instead of ! for checking pointers.

Consistent spacing around {, *, casts.

Declare 0-parameter functions as (void) not ().

Integer valued functions return -1 on failure, 0 on success.
2011-01-11 13:01:13 -05:00
Russ Cox 240679608c mkfs: avoid clash with system struct stat 2011-01-10 10:43:40 -05:00
Russ Cox e92fd6142d mkfs: avoid out of bounds access to sb in wsect 2011-01-02 17:59:57 -05:00
Robert Morris 2ea6c764c3 even more fabulous exec 2010-09-29 14:12:26 -04:00
Robert Morris 06feabecee check exec() arg length
fix double iunlockput
2010-09-27 16:17:57 -04:00
Robert Morris 4655d42e3b copyout() copies data to a va in a pagetable, for exec() &c
usertest that passes too many arguments, break exec
2010-09-27 16:14:33 -04:00
Robert Morris a9183883b8 map kernel instructions r/o 2010-09-20 06:00:22 -04:00
Robert Morris 26d11ee8dc Merge branch 'master' of git+ssh://amsterdam.csail.mit.edu/home/am0/6.828/xv6 2010-09-19 13:48:22 -04:00
Robert Morris 05d66b0629 my comment is wrong, exec handles BSS fine 2010-09-19 13:47:52 -04:00
Robert Morris 4587b35847 exec questions 2010-09-19 07:18:42 -04:00
Austin Clements 4c274cef74 Simplify boot loader by removing some JOS'isms 2010-09-15 16:15:07 -04:00
Robert Morris faad047ab2 change some comments, maybe more informative
delete most comments from bootother.S (since copy of bootasm.S)
ksegment() -> seginit()
move more stuff from main() to mainc()
2010-09-13 15:34:44 -04:00
Austin Clements 124fe7e457 Rev 4 2010-09-03 15:47:28 -04:00
Austin Clements cc21c06e3b Update example in TOC footer 2010-09-02 19:03:48 -04:00
Austin Clements 588644f472 Consistent style in defs.h 2010-09-02 19:01:25 -04:00
Austin Clements 8440dbfee1 Get consoleintr back on one page 2010-09-02 18:54:50 -04:00
Austin Clements 08eef9eae5 Get cgaputc and consputc back on the same page 2010-09-02 18:50:49 -04:00
Austin Clements 5bf11c50b5 Get rid of the blank page in picirq.c. It misaligs things now. 2010-09-02 18:36:06 -04:00
Austin Clements 79cd8b3eed Simplify allocuvm/deallocuvm to operate in a contiguous memory model. This makes their interface match up better with proc->sz and also simplifies the callers (it even gets the main body of exec on one page). 2010-09-02 18:28:36 -04:00
Austin Clements d49d31381d Nits 2010-09-02 17:03:19 -04:00
Austin Clements 9a4670a138 Comment inituvm and loaduvm 2010-09-02 16:39:55 -04:00
Austin Clements 93a1e4cb07 Fix comment capitalization 2010-09-02 16:36:38 -04:00
Austin Clements f25a3f9a41 Rearrange vm.c so it's in logical order and prints nicely. Shorten a few functions in uninteresting ways to make them fit. 2010-09-02 16:23:15 -04:00
Austin Clements f53e6110be Simplify inituvm and userinit by assuming initcode fits on a page 2010-09-02 15:42:25 -04:00
Austin Clements b3cfd7fc37 Simplify freevm using deallocuvm 2010-09-02 15:18:19 -04:00
Austin Clements c7c21467c3 Oops. Broke the build when I rearranged proc.c 2010-09-02 14:30:06 -04:00
Austin Clements d599aa2e40 Remove unused nop_pause function. 2010-09-02 14:08:45 -04:00
Austin Clements d8828817d7 Rearrange proc.h and proc.c to get our action-packed spreads back (mostly). They also make sense in this order, so it's not just for page layout. 2010-09-02 04:15:17 -04:00
Austin Clements dd3ecd42cd Re-re-arrange bootasm and bootother. We can't get bootasm and bootmain on the same page, but this will make them easier to flip between. 2010-09-02 04:06:35 -04:00
Austin Clements d2c7f64978 I totally misunderstood the even/odd spec. Add some docs, remove my 'left+' hack, and orthogonalize left/right versus even/odd so you can specify them independently. 2010-09-02 04:03:42 -04:00
Austin Clements 9d7a63e073 Specify in runoff.spec which side sheet 1 is on, since it keeps changing 2010-09-02 03:57:20 -04:00
Austin Clements 0fa1ab632f Pack five columns into cross-ref. This saves us an entire page and fixes the single dangling line. 2010-09-02 03:56:36 -04:00
Austin Clements 1280d26802 Oops, missed a comment about the stack guard 2010-09-02 03:36:39 -04:00
Austin Clements 4d245c79f9 Add Nickolai and myself and scrunch two lines out of the text elsewhere 2010-09-02 03:25:33 -04:00
Austin Clements d3ecf3eb44 Slight simplification of copyuvm. We could simplify other things now that processes are contiguous, but we'd have to think harder about the error paths. 2010-09-01 17:14:58 -04:00
Austin Clements b1d41d6788 Remove the stack guard page. Processes are now contiguous from 0 to proc->sz, which means our syscall argument validation is correct. Add a pointer validation test and remove the stack test, which tested for the guard page. 2010-09-01 16:46:37 -04:00
Austin Clements 41c4bbb505 Make it easy to change the number of CPUs 2010-09-01 02:14:35 -04:00
Austin Clements b0751a3e9b Space police 2010-09-01 00:41:25 -04:00
Austin Clements 5efca9054f Tab police 2010-09-01 00:32:27 -04:00
Austin Clements 5c4dc7395b Merge branch 'master' of git+ssh://am.lcs/home/am0/6.828/xv6 2010-09-01 00:31:04 -04:00
Austin Clements ba04b3e70e Fix similar leak in copyuvm 2010-09-01 00:27:12 -04:00
Austin Clements dd645ef119 Cleanup if allocuvm fails to alloc. Add a test. 2010-08-31 21:49:49 -04:00
Robert Morris 23c3e52c2f Merge branch 'master' of git+ssh://amsterdam.csail.mit.edu/home/am0/6.828/xv6 2010-08-31 19:21:52 -04:00
Robert Morris 3597d5dc70 oops. last minute simplicifaction to kalloc(). 2010-08-31 19:21:33 -04:00
Austin Clements 5048762c7e Page break kalloc.c 2010-08-31 17:52:03 -04:00
Austin Clements 87b2099ae4 Our proc.c alignment is perfect. Since ksegment/usegment went away, we get a column back, so we get our two action-packed spreads. 2010-08-31 17:49:47 -04:00
Austin Clements 13b3f4d2e3 Make it possible to express half-page preferences 2010-08-31 17:46:30 -04:00
Austin Clements fd462b6a01 Got the meat of spinlocks on one spread 2010-08-31 17:40:21 -04:00
Austin Clements 6a6bf37c3c Swap bootmain.c and bootother.S. This puts the whole boot process on one spread, though it separates the two asm files. 2010-08-31 17:35:17 -04:00
Austin Clements c7ceb71d57 Sheet 1 is a right page now because of the (much) longer cross-ref 2010-08-31 17:33:04 -04:00