Fix a VLA problem

see testcase, reduced example of a situation reported by
Kyryl Melekhin in https://github.com/kyx0r/neatvi/ .
Problem is that setting up the VLA sp-save in a scope that isn't
entered at runtime leaves traces of it in outer scopes that then
try to restore the stack pointer from uninitialized slots.
This commit is contained in:
Michael Matz 2021-02-03 04:30:11 +01:00
parent d6f2d58158
commit fbef90a703
4 changed files with 69 additions and 12 deletions

View file

@ -120,7 +120,7 @@ short nb_temp_local_vars;
static struct scope { static struct scope {
struct scope *prev; struct scope *prev;
struct { int loc, num; } vla; struct { int loc, locorig, num; } vla;
struct { Sym *s; int n; } cl; struct { Sym *s; int n; } cl;
int *bsym, *csym; int *bsym, *csym;
Sym *lstk, *llstk; Sym *lstk, *llstk;
@ -7268,8 +7268,12 @@ static void vla_restore(int loc)
static void vla_leave(struct scope *o) static void vla_leave(struct scope *o)
{ {
if (o->vla.num < cur_scope->vla.num) struct scope *c = cur_scope, *v = NULL;
vla_restore(o->vla.loc); for (; c != o && c; c = c->prev)
if (c->vla.num)
v = c;
if (v)
vla_restore(v->vla.locorig);
} }
/* ------------------------------------------------------------------------- */ /* ------------------------------------------------------------------------- */
@ -7281,6 +7285,7 @@ void new_scope(struct scope *o)
*o = *cur_scope; *o = *cur_scope;
o->prev = cur_scope; o->prev = cur_scope;
cur_scope = o; cur_scope = o;
cur_scope->vla.num = 0;
/* record local declaration stack position */ /* record local declaration stack position */
o->lstk = local_stack; o->lstk = local_stack;
@ -7600,7 +7605,8 @@ again:
goto block_after_label; goto block_after_label;
} else if (t == TOK_GOTO) { } else if (t == TOK_GOTO) {
vla_restore(root_scope->vla.loc); if (cur_scope->vla.num)
vla_restore(cur_scope->vla.locorig);
if (tok == '*' && gnu_ext) { if (tok == '*' && gnu_ext) {
/* computed goto */ /* computed goto */
next(); next();
@ -8566,11 +8572,14 @@ static void decl_initializer_alloc(CType *type, AttributeDef *ad, int r,
if (NODATA_WANTED) if (NODATA_WANTED)
goto no_alloc; goto no_alloc;
/* save current stack pointer */ /* save before-VLA stack pointer if needed */
if (root_scope->vla.loc == 0) { if (cur_scope->vla.num == 0) {
struct scope *v = cur_scope; if (cur_scope->prev && cur_scope->prev->vla.num) {
gen_vla_sp_save(loc -= PTR_SIZE); cur_scope->vla.locorig = cur_scope->prev->vla.loc;
do v->vla.loc = loc; while ((v = v->prev)); } else {
gen_vla_sp_save(loc -= PTR_SIZE);
cur_scope->vla.locorig = loc;
}
} }
vla_runtime_type_size(type, &a); vla_runtime_type_size(type, &a);

View file

@ -0,0 +1,40 @@
typedef __SIZE_TYPE__ size_t;
extern int printf(const char*, ...);
extern size_t strlen(const char*);
char str[] = "blabla";
int g;
int main()
{
//char helpme[strlen(str) + 1];
int i = 0;
#if 0
if (g) {
char buf[strlen(str) + 10];
buf[0] = 0;
}
alabel:
printf("default: i = %d\n", i);
#else
for (i = 0; i < 5; i++) {
switch (i) {
case 10:
if (g) {
char buf[strlen(str) + 10];
buf[0] = 0;
goto do_cmd;
}
break;
case 1:
printf("reached 3\n");
do_cmd:
printf("after do_cmd");
break;
default:
g++;
printf("default: i = %d\n", i);
break;
}
}
#endif
return 0;
}

View file

@ -0,0 +1,5 @@
default: i = 0
reached 3
after do_cmddefault: i = 2
default: i = 3
default: i = 4

View file

@ -48,11 +48,14 @@ void test3()
int count = 10; int count = 10;
void *addr[count]; void *addr[count];
while(count--) { while(count--) {
int a[f()]; int b[f()];
if (count >= 0) {
int a[f()];
addr[count] = a; addr[count] = a;
continue; continue;
}
} }
if(addr[9] == addr[0]) { if(addr[9] == addr[0]) {